keybase / keybase/client

Git file view could use some love

Open
#19,742 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

I noticed today while trying to read a file via the git file view on app, the display could really use some work. I get that you're trying to limit the width of the view, but it makes viewing code really difficult. Also, there is some odd stuff going on with longs lines. I've included an image below to illustrate what I'm referring to.

Screenshot 2019-09-17 at 14 58 03

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the app's git file view and compare its display with the linked screenshot. Investigate the constrained view width and the handling of long lines; done means code is easier to read and long lines render correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.