keybase / keybase/client

Buttons labeling for screen readers

Open
#19,355 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Hello.
When using the desktop app with the latest NVDA snapshot or the mobile app with VoiceOver i unfortunately found out that almost all the buttons aren't correctly labeled, they have no semantic information at all, actually. The same applies to the main navigation. For example joining the airdrop or authorizing a new device was basically a game of luck (thank goodness for the command line device add flow and some luck with the QR scanning). Yes, i know, this is basically a specific issue of #10370, but because that got exactly no response, i thought it wouldn't be as bad an idea to bump this one again.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the unlabeled buttons and main-navigation issues in the desktop and mobile apps with NVDA and VoiceOver, focusing on the airdrop and device-authorization flows. Review the existing accessibility behavior and issue #10370; done means buttons and navigation expose meaningful semantic labels and the affected flows are usable with both screen readers.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, react-native
Domain
accessibility, desktop, mobile
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.