keybase / keybase/client

Add timezone info to chat messages

Open
#19,073 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

It would be nice to see the sender's local timestamp of chat messages in the gui client, e.g. when hovering the timestamp of the message (which is in my local time), it would show a popup next to it with the local time & timezone of the sender.

Possible rendition:
keybase-chat-time-annotated

The chat json api could convey this by adding a new sent_in_tz field, indicating just the timezone. Example:

{
    "msg": {
        "id": 52853,
        // ...
        "sent_at": 1566533288,
        "sent_at_ms": 1566533288566,
        "sent_in_tz": "GMT",
        "content": {
            // ...

The format of the value could also be like "UTC+01" or "Europe/Amsterdam" or "+0100", whatever you feel works best.

There is a slight privacy concern here; people might not want to reveal even their rough location, so a setting in the client for omitting timezone information in chat messages might be in order.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin with the chat JSON API and the GUI client's message timestamp hover behavior described in the issue; check how sent_at is represented and consumed. Done means sender timezone information can be conveyed and shown beside the timestamp, with a client setting that addresses the stated privacy concern.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.