gpg defaulting to ~/.gnupg with GNUPGHOME defined
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
Between 0.7.8(node) and 1.0.9-0, the keybase client stopped being able to use gpg’s GNUPGHOME env var on my OSX install. I had not refreshed homebrew in a while when I installed keybase, and when it encouraged me to update right after login, it then promptly could not read the pubring it just wrote.
Oddly the 1.0.9-1 client works fine on my Linux desktop with this same env var defined, as this seems to come down to the service that is now used, not being passed this information when it is created on OSX.
https://github.com/keybase/client/blob/ef7267389aadab8791db10fa4427339f840d98b3/go/libcmdline/cmdline.go#L331
Relatedly, this --pgpdir option does not seem to work
Capture from terminal of install, update, failure https://gist.github.com/johndrinkwater/b2e014fef3623cbd4602
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at go/libcmdline/cmdline.go around line 331 and compare how the macOS service is created with the Linux behavior. Reproduce the failure with GNUPGHOME defined and with --pgpdir, then verify that the service can read the pubring written during the update. Done means both GNUPGHOME and --pgpdir work on the affected macOS install.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, macos
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100