keybase / keybase/client

PDF preview from Keybase.pub do not work on chrome

Open
#19,049 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Keybase.pub/[username] page seems to try to load PDF files from [username].keybase.pub into an iframe to preview it , but [username].keybase.pub `x-frame-options` header with `ALLOW-FROM` is [not available on chrome or safari](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options)

i haven't checked much but it may be able to be fixed by using `Content-Security-Policy`, with `frame-ancestors` and [that should work for chrome,firefox,edge and safari](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors). And if compatiblity is needed, i believe both headers can be set and `x-frame-options` ill just get ignored if `Content-Security-Policy ` is set and compatible

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Keybase.pub PDF preview path and checking the response headers from [username].keybase.pub in Chrome and Safari. Confirm the intended header behavior and verify that PDF files load in the iframe across the affected browsers.

Written by the indexing model from the issue text.

Assessment

Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.