keybase / keybase/client

Sending multiline quotes is tedious

Open
#18,956 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

What I did

I sent a message that had a multi-line quote of text. e.g.:

Hi, I found this description, do you think it's adequate?
>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
>
>Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
What happened

The quote displayed but with a > for the blank line in the middle of the quote instead of inserting a blank line in the middle of the quote.
Screen Shot 2019-08-15 at 9 11 22 AM

What I expected to happen

I expected the message to look like this:
Screen Shot 2019-08-15 at 9 12 30 AM
This is what it looks like if for that blank line I insert a space, e.g.: > instead of >. We can manually use this work around but it'd be great if Keybase handled multi-paragraph quotes better out of the box.

Other better solutions

There's an issue here specifically with the > and a blank line, but there might be a better overall solution that Slack has adopted. Slack supports the >>> at the beginning of the quote that causes all the lines for the rest of the message to become quoted. e.g.: https://twitter.com/slackhq/status/472098178838179840.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start by locating the client’s multiline quote handling; done means blank quoted lines render as blank lines without requiring a space, with regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.