keybase / keybase/client

QRL proof failed, fix seems simple (remove lower casing)

Open
#18,428 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

The QRL proof has failed after several attempts. I noticed that the QRL address was being lower cased in the url to the QRL side of things. I suspect this is also happening to the signature hash generated for verification. This easily accounts for the failure since the hash would not match and neither would the address. When performing the fix, be sure to also check that the QRL address is not being lower cased when generating the signature hash or the same problem will persist.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the QRL proof flow from the address URL to the signature hash generation, checking where either value is lower cased. The issue is done when the original address casing is preserved in both places and QRL proof verification succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.