keybase / keybase/client

Location command on Android causes app crash

Open
#18,395 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Updated the Android app to support the /location command. Entered the command and the app immediately crashed.

I then went into the keybase app permissions and added the "Location" permission, and app worked as expected.

Other apps typically prompt a request for location permissions when a feature requiring those permissions is being used without those permissions being granted.

Phone: OnePlus 7 Pro - Oxygen OS 9.5.8.GM21AA | Android 9

Can provide more information if needed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash when entering the /location command without the Android Location permission, then inspect the Android permission handling for that command. Done means the app requests Location permission instead of crashing and the command works after permission is granted.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.