keybase / keybase/client

“Flip again” button shouldn't initiate flip without confirmation

Open
#17,861 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

In the current version of Keybase desktop client, “Flip again” button initiates a flip immediately after clicking it. This behaviour, together with the fact that once started, there is no way to cancel a flip, makes it easy for the user to accidentally initiate an unwanted flip, spamming user's current channel. After clicking the button, there should either be a timeout before starting a new flip, allowing the user to cancel it if the initiation was a misclick, or some way of confirmation from the user, making sure they indeed wanted to start a new flip by clicking the button.

One way to make this feature less error prone might be to prefill the message box with the correct flip command, requiring the user to send the message to initiate the flip. If the user clicks the button in a mistake, they could delete the message instead of sending it. Special care would be needed in cases when there already is some text in the message box. The user should not lose an unsent message because of this kind of misclick.

This issue is related to issue #17662, where it is shown how this behaviour can lead to excessive flip spam in cases where the client might fail to deliver a message, such as with an unstable network connection.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file, test, or entry point is identified in the issue. Start by locating the desktop client's “Flip again” flow, then define a confirmation or cancellation path that avoids starting an unwanted flip and preserves any unsent message; done means accidental clicks cannot initiate a flip.

Written by the indexing model from the issue text.

Assessment

Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.