Windows: Clean up registry entry on uninstall
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
Someone reported this before but I never got around to it - there is an open ticket somewhere on this still. I just built an installer with this change and tested it. The key it cleans up is under `HKCU\Software\Classes\Applications\Explorer.exe\Drives`
```
diff --git a/packaging/windows/WIXInstallers/KeybaseApps/KeybaseApps.wxs b/packaging/windows/WIXInstallers/KeybaseApps/KeybaseApps.wxs
index e8b3baae6e..f933ea1cc4 100644
--- a/packaging/windows/WIXInstallers/KeybaseApps/KeybaseApps.wxs
+++ b/packaging/windows/WIXInstallers/KeybaseApps/KeybaseApps.wxs
@@ -30,6 +30,7 @@
FAKE_PROPERTY
+
@@ -270,6 +271,14 @@
Execute="immediate"
Return="ignore"/>
+
+
+
+
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in packaging/windows/WIXInstallers/KeybaseApps/KeybaseApps.wxs and review the uninstall sequence and custom actions shown in the issue. Build and test the Windows installer, then verify that uninstalling removes the registry entry under HKCU\Software\Classes\Applications\Explorer.exe\Drives without affecting upgrades.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, xml
- Domain
- build-system, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100