Panic on attempting to sign or PGP sign with message
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
Whenever attempting to use commands such as:
keybase pgp sign -i file -m "message"
Or
keybase sign -i file -m "message"
The following panic occurs:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0x18bfecb]
goroutine 1 [running]:
github.com/keybase/client/go/client.(*UnixFilter).Close(0xc042248468, 0x225cd60, 0xc0422f1310, 0x0, 0x225cd60)
c:/work/src/github.com/keybase/client/go/client/files.go:373 +0x3b
github.com/keybase/client/go/client.(*CmdSign).Run(0xc042248460, 0xc0422481c0, 0x30a6420)
c:/work/src/github.com/keybase/client/go/client/cmd_sign.go:102 +0x21a
main.mainInner(0xc042159000, 0x0, 0x0, 0x0, 0x0, 0x0)
c:/work/src/github.com/keybase/client/go/keybase/main.go:247 +0x77e
main.main()
c:/work/src/github.com/keybase/client/go/keybase/main.go:71 +0xcb
My log ID for this issue is is 8621bc30d1ff112558f8b21c.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with go/client/files.go at UnixFilter.Close and go/client/cmd_sign.go at CmdSign.Run, using the stack trace as the entry point. Reproduce the keybase pgp sign or keybase sign command with both -i and -m; done means neither command panics and the signing result is returned normally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, cryptography
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100