macOS: CMD+W should Close and not Quit the Keybase client
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
Steps to reproduce
- Run Keybase client
Version 3.1.2-20190312142912+4c383e6a53 (3.1.2-20190312142912+4c383e6a53on macOS 10.14.3 - Close the Keybase client by pressing Command+W
Current behaviour
- Keybase client closes and the icon on the dock is removed. (Same behaviour as Quitting a macOS app, i.e. pressing Command+Q). The top bar icon remains.
Expected behaviour
- Keybase client should close on CMD+W, but not Quit. I.e. the dock icon should persist, as this is the expected behaviour of Mac apps.
Side note
Thanks for an awesome application and service. Quickly becoming an integral part of my workflow. ❤️
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Keybase client’s macOS handling for Command+W and compare its behavior with Command+Q. Reproduce the issue on macOS 10.14.3 using the reported client version, then verify that Command+W closes the client window while the dock icon remains and the top bar icon is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- macos
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100