User assertions do not work anymore
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
After upgrade to Keybase 1.0.7, user assertions do not work anymore:
$ keybase pgp verify --infile .public_keys/user.key --detached .public_keys/user.key.asc --signed-by "someuser@github || someother@github"
▶ ERROR assertion parse error: Unexpected 'OR' operator
There is really no documentation on this, and in the source code I see:
func NewLexer(s string) *Lexer {
// We're allowing '||' or ',' for disjunction
// We're allowing '&&' or '+' for conjunction
So I guess this has been broken.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with keybase pgp verify and trace the assertion parser from the NewLexer entry point shown in the issue. Check why || is rejected despite the lexer comment, then verify that the documented disjunction syntax is accepted without the assertion parse error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100