keybase / keybase/client

Focus Stealing

Open
#15,900 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

Keybase started updating automatically, the Electron app window popped up, I was wrenched from my window of choice and yanked out of my space and thrown into another desktop so that I could see your electron app window with the "Keybase is loading".

Suffice to say the thing I was doing at the time was completely ruined, and you're application is to blame.

https://en.wikipedia.org/wiki/Focus_stealing

> In computing, focus stealing is a mode error produced when a program not in focus (e.g. minimized or operating in background) places a window in the foreground and redirects all keyboard input to that window. This is considered to be an annoyance or hazard to some users because the program may steal the focus while their attention is not on the computer screen, such as when typing while reading copy to the side.

The Keybase Electron application is guilty of **focus stealing**. Stop it.

You don't need to pop up the Keybase main window when you do an update, you've got a perfectly good menu icon. Show it up in the background and make it bounce in the dock, or highlight the menu bar icon and tell me there's an update to install just **don't steal my focus**. I can't even turn auto-update off, at least ask me!

![image](https://user-images.githubusercontent.com/58855/52311247-3f97df00-299e-11e9-9829-9785180e4299.png)

OS: MacOS Mojave 10.14.1
Keybase version after update: Version 3.0.0-20190205183613+6394d03e6c

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the Electron auto-update flow and the code that shows the Keybase main window on macOS. Reproduce an update on macOS Mojave or a comparable macOS setup, then verify that updates remain in the background and do not move focus to the application window.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.