keybase / keybase/client

Nag screen button for "Create a paper key" does the wrong thing

Open
#13,810 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

On the People page there's a nag screen to "Create a paper key".

Clicking the button takes you the Devices screen.

In addition to the devices (that you can click on) is an "+ Add new..." button at the top of the screen. If you click that, a drop down shows "New Paper Key" as option #3. If you click on any device you end up following a different path that does not allow you to create a paper key.

So "Create a paper key" button takes you to a Device screen with many things to click on, to add a paper key you have to click "+ Add new...", then click option #3.

This is bad UI.

Since it's not obvious that a "paper key" is a "device", a cleaner way to implement this would be to have the original "Create a paper key" button just create a new paper key directly, without any of the intermediate steps.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the People page's "Create a paper key" button and trace the navigation it triggers to the Devices screen. Reproduce the flow, then verify that the button reaches paper-key creation directly without requiring the intermediate device list and menu selection.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, react-native
Domain
frontend, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.