keybase / keybase/client

Keybase Chat injected button fails on Facebook profiles without username

Open
#13,287 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

Facebook users can exist without usernames, and in this case, their profile links are shown as below

```
https://www.facebook.com/profile.php?id=x
```

where `x` is their user ID. On these pages, interacting with an injected "Keybase Chat" button will intend to send communications to `profile.php@facebook`, as shown below.

![screenshot from 2018-08-14 16-11-40](https://user-images.githubusercontent.com/9065758/44113036-2949d348-9fdd-11e8-84ab-3f00f0c40a38.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the injected Keybase Chat button on a Facebook profile URL using the profile.php?id=x form, then trace the profile parsing and recipient-building entry point. Confirm the behavior against a Facebook profile with a username as well, and consider the issue done when both forms identify the intended Facebook recipient rather than profile.php@facebook.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.