keybase / keybase/client

Notification badge should reset on visit, not leave

Open
#12,795 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

The notification badge for, e.g, a new follower, doesn't reset until you leave the "People" page.

Several issues related to this have been filed, where users think that it won't reset at all.

I propose that the less surprising behavior would be to reset the number when you click the tab. This is how most apps I use behave, and it took me a few weeks to figure out what Keybase was actually doing.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the People page and its notification-badge entry point, tracing when the badge count is cleared after visiting the tab. The work is done when opening the People tab resets the badge immediately instead of waiting until the user leaves the page.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.