keybase / keybase/client

Please allow desktop app to be built without requiring electron downloads.

Open
#10,546 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

When running yarn run package --platform linux --appVersion=${tagname#v} to build the desktop app (this seems to be handled in https://github.com/keybase/client/blob/master/shared/desktop/package.js) this really only has one option and that is to download prebuilt electron packages and build everything into some vendored binary distribution in shared/desktop/release/linux-x64/Keybase-linux-x64/

The only thing that is really needed is shared/desktop/release/linux-x64/Keybase-linux-x64/resources/app/, and from a distro packaging perspective it is far superior to e.g. package this as /usr/lib/keybase/ and use a launcher script that runs electron /usr/lib/keybase/ via a system electron installation.

I would appreciate if there was some (documented) method to simply generate the app directory without requiring all that extra work, and thereby simplifying the process of distro packaging for Keybase.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with shared/desktop/package.js and the existing output under shared/desktop/release/linux-x64/Keybase-linux-x64/. Determine how the packaging command can produce only resources/app without downloading or vendoring Electron; done means a documented build path generates that app directory for distro packaging.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron
Domain
build-system, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.