keybase chat ls causes panic
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
$ keybase chat ls
panic: wrong case accessed
goroutine 1 [running]:
github.com/keybase/client/go/protocol/chat1.MessageSystem.Addedtoteam(0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/build/go/src/github.com/keybase/client/go/protocol/chat1/local.go:287 +0x9c
github.com/keybase/client/go/client.formatSystemMessage(0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/Users/build/go/src/github.com/keybase/client/go/client/chat_cli_rendering.go:436 +0x25a
github.com/keybase/client/go/client.newMessageViewValid(0xc42017b180, 0xc42020a300, 0x20, 0x20, 0xc42012e490, 0x10, 0x10, 0x1, 0xc42012e4a0, 0x10, ...)
/Users/build/go/src/github.com/keybase/client/go/client/chat_cli_rendering.go:512 +0xbe6
github.com/keybase/client/go/client.newMessageView(0xc42017b180, 0xc42020a300, 0x20, 0x20, 0x1, 0xc420119800, 0x0, 0x0, 0x0, 0x0, ...)
/Users/build/go/src/github.com/keybase/client/go/client/chat_cli_rendering.go:623 +0x303
github.com/keybase/client/go/client.conversationListView.show(0xc4200b5600, 0x5, 0x5, 0xc42017b180, 0xc4202796d8, 0x5, 0xc42023f400, 0x3, 0x4)
/Users/build/go/src/github.com/keybase/client/go/client/chat_cli_rendering.go:219 +0x372
github.com/keybase/client/go/client.(*cmdChatList).Run(0xc42011e980, 0xc420264540, 0x5e10af0)
/Users/build/go/src/github.com/keybase/client/go/client/cmd_chat_list.go:42 +0x13e
main.mainInner(0xc42017b180, 0x0, 0x0)
/Users/build/go/src/github.com/keybase/client/go/keybase/main.go:159 +0x71b
main.main()
/Users/build/go/src/github.com/keybase/client/go/keybase/main.go:64 +0xa6
my log id: 164ce2b8932c629279ad641c
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the panic with keybase chat ls, then trace the call from cmd_chat_list.go through chat_cli_rendering.go to protocol/chat1/local.go. Confirm the affected system message path and identify a focused regression check; done means the command lists chats without panicking.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100