Bug: Attempting to save a photo from a message triggers a crash
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9.2k
- Forks
- 1.3k
- Avg merge
- 12h 58m
- Merged PRs (30d)
- 56
Description
Steps to Reproduce
- Download new copy of app with no previous permissions (maybe necessary)
- Create a new account (maybe necessary)
- Have someone send you a photo
- Attempt to download photo
Screenshot examples
Crash report
TLDR
Termination Reason: TCC, This app has crashed because it attempted
to access privacy-sensitive data without a usage description.
The app's Info.plist must contain an NSPhotoLibraryAddUsageDescription
key with a string value explaining to the user how the app uses this data.
Full Crash
Incident Identifier: 256982F6-2078-4A94-AB6B-AE0A7003569E
CrashReporter Key: 35d3e091609b36e3d98ed4e8f8a9a79bbdfaf00b
Hardware Model: iPhone8,1
Process: Keybase [3057]
Path: /private/var/containers/Bundle/Application/947B50FC-CC76-41DE-A967-5E01153A3E67/Keybase.app/Keybase
Identifier: keybase.ios
Version: 39 (1.0.12)
Code Type: ARM-64 (Native)
Role: Foreground
Parent Process: launchd [1]
Coalition: keybase.ios [728]
Date/Time: 2018-02-04 12:36:52.6190 -0600
Launch Time: 2018-02-04 11:25:36.1630 -0600
OS Version: iPhone OS 11.2.2 (15C202)
Baseband Version: 4.30.02
Report Version: 104
Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Termination Reason: TCC, This app has crashed because it attempted to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSPhotoLibraryAddUsageDescription key with a string value explaining to the user how the app uses this data.
Triggered by Thread: 17
Filtered syslog:
None found
Thread 0 name: Dispatch queue: com.apple.main-thread
Thread 0:
0 libsystem_kernel.dylib 0x0000000181f07568 0x181f06000 + 5480
1 libsystem_kernel.dylib 0x0000000181f073e0 0x181f06000 + 5088
2 CoreFoundation 0x00000001823be308 0x1822d0000 + 975624
3 CoreFoundation 0x00000001823bbed4 0x1822d0000 + 966356
4 CoreFoundation 0x00000001822dbe58 0x1822d0000 + 48728
5 GraphicsServices 0x0000000184188f84 0x18417e000 + 44932
6 UIKit 0x000000018ba3067c 0x18b9bd000 + 472700
7 Keybase 0x0000000104b3eb64 0x104b28000 + 93028
8 libdyld.dylib 0x0000000181df856c 0x181df7000 + 5484
Thread 1:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
3 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 2 name: Dispatch queue: go_bridge_queue_read
Thread 2:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b02384 0x104b28000 + 16622468
3 Keybase 0x0000000104b44080 0x104b28000 + 114816
4 libdispatch.dylib 0x0000000181d92a54 0x181d91000 + 6740
5 libdispatch.dylib 0x0000000181d92a14 0x181d91000 + 6676
6 libdispatch.dylib 0x0000000181d9c96c 0x181d91000 + 47468
7 libdispatch.dylib 0x0000000181d9d2fc 0x181d91000 + 49916
8 libdispatch.dylib 0x0000000181d9dd20 0x181d91000 + 52512
9 libdispatch.dylib 0x0000000181da603c 0x181d91000 + 86076
10 libsystem_pthread.dylib 0x000000018203af1c 0x18203a000 + 3868
11 libsystem_pthread.dylib 0x000000018203ab6c 0x18203a000 + 2924
Thread 3 name: com.apple.uikit.eventfetch-thread
Thread 3:
0 libsystem_kernel.dylib 0x0000000181f07568 0x181f06000 + 5480
1 libsystem_kernel.dylib 0x0000000181f073e0 0x181f06000 + 5088
2 CoreFoundation 0x00000001823be308 0x1822d0000 + 975624
3 CoreFoundation 0x00000001823bbed4 0x1822d0000 + 966356
4 CoreFoundation 0x00000001822dbe58 0x1822d0000 + 48728
5 Foundation 0x0000000182d11594 0x182d05000 + 50580
6 Foundation 0x0000000182d309ac 0x182d05000 + 178604
7 UIKit 0x000000018c59a7b8 0x18b9bd000 + 12441528
8 Foundation 0x0000000182e130f4 0x182d05000 + 1106164
9 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
10 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
11 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 4:
0 Keybase 0x0000000104ca2674 0x104b28000 + 1549940
1 Keybase 0x0000000104c74cf0 0x104b28000 + 1363184
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 5:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 6:
0 Keybase 0x0000000104ca2674 0x104b28000 + 1549940
1 Keybase 0x0000000104c74cf0 0x104b28000 + 1363184
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 7:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 8:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 9:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 10 name: com.facebook.react.JavaScript
Thread 10:
0 JavaScriptCore 0x0000000188e0dd3c 0x188dd6000 + 228668
1 JavaScriptCore 0x0000000188e0dcd4 0x188dd6000 + 228564
2 JavaScriptCore 0x0000000189557a20 0x188dd6000 + 7871008
3 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
4 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
5 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
6 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
7 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
8 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
9 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
10 JavaScriptCore 0x000000018955b454 0x188dd6000 + 7885908
11 JavaScriptCore 0x000000018955b454 0x188dd6000 + 7885908
12 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
13 JavaScriptCore 0x000000018955b454 0x188dd6000 + 7885908
14 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
15 JavaScriptCore 0x000000018955b8bc 0x188dd6000 + 7887036
16 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
17 JavaScriptCore 0x000000018955b454 0x188dd6000 + 7885908
18 JavaScriptCore 0x000000018955b3f0 0x188dd6000 + 7885808
19 JavaScriptCore 0x0000000189554900 0x188dd6000 + 7858432
20 JavaScriptCore 0x0000000189433190 0x188dd6000 + 6672784
21 JavaScriptCore 0x0000000188e18490 0x188dd6000 + 271504
22 JavaScriptCore 0x000000018946baac 0x188dd6000 + 6904492
23 JavaScriptCore 0x0000000189554a48 0x188dd6000 + 7858760
24 JavaScriptCore 0x0000000188e184d8 0x188dd6000 + 271576
25 JavaScriptCore 0x000000018907c444 0x188dd6000 + 2778180
26 JavaScriptCore 0x0000000188e18240 0x188dd6000 + 270912
27 Keybase 0x0000000104c1d948 0x104b28000 + 1005896
28 Keybase 0x0000000104c3d668 0x104b28000 + 1136232
29 Keybase 0x0000000104c3c9fc 0x104b28000 + 1133052
30 Keybase 0x0000000104bcb00c 0x104b28000 + 667660
31 Keybase 0x0000000104bc32a4 0x104b28000 + 635556
32 CoreFoundation 0x00000001823be790 0x1822d0000 + 976784
33 CoreFoundation 0x00000001823be060 0x1822d0000 + 974944
34 CoreFoundation 0x00000001823bbd4c 0x1822d0000 + 965964
35 CoreFoundation 0x00000001822dbe58 0x1822d0000 + 48728
36 Keybase 0x0000000104ba5b44 0x104b28000 + 514884
37 Foundation 0x0000000182e130f4 0x182d05000 + 1106164
38 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
39 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
40 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 11:
0 libsystem_kernel.dylib 0x0000000181f280f0 0x181f06000 + 139504
1 libsystem_pthread.dylib 0x000000018203ece4 0x18203a000 + 19684
2 libc++.1.dylib 0x00000001815dff34 0x1815d8000 + 32564
3 JavaScriptCore 0x0000000189780168 0x188dd6000 + 10133864
4 JavaScriptCore 0x000000018978003c 0x188dd6000 + 10133564
5 JavaScriptCore 0x000000018977fec0 0x188dd6000 + 10133184
6 JavaScriptCore 0x00000001897801b8 0x188dd6000 + 10133944
7 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
8 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
9 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 12 name: com.apple.CoreMotion.MotionThread
Thread 12:
0 libsystem_kernel.dylib 0x0000000181f07568 0x181f06000 + 5480
1 libsystem_kernel.dylib 0x0000000181f073e0 0x181f06000 + 5088
2 CoreFoundation 0x00000001823be308 0x1822d0000 + 975624
3 CoreFoundation 0x00000001823bbed4 0x1822d0000 + 966356
4 CoreFoundation 0x00000001822dbe58 0x1822d0000 + 48728
5 CoreFoundation 0x000000018232af54 0x1822d0000 + 372564
6 CoreMotion 0x00000001877490e8 0x1876c9000 + 524520
7 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
8 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
9 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 13:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 14:
0 Keybase 0x0000000104ca26e0 0x104b28000 + 1550048
1 Keybase 0x0000000104c7420c 0x104b28000 + 1360396
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 15:
0 Keybase 0x0000000104ca264c 0x104b28000 + 1549900
1 Keybase 0x0000000104c74c6c 0x104b28000 + 1363052
2 Keybase 0x0000000105b00c50 0x104b28000 + 16616528
3 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
4 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
5 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 16 name: Dispatch queue: com.apple.mobileslideshow.accessCallbacks
Thread 16:
0 libsystem_kernel.dylib 0x0000000181f075a4 0x181f06000 + 5540
1 libdispatch.dylib 0x0000000181d94f04 0x181d91000 + 16132
2 libdispatch.dylib 0x0000000181d958b4 0x181d91000 + 18612
3 AssetsLibraryServices 0x000000018f9f09c4 0x18f9d3000 + 121284
4 AssetsLibraryServices 0x000000018f9dadfc 0x18f9d3000 + 32252
5 libdispatch.dylib 0x0000000181d92a54 0x181d91000 + 6740
6 libdispatch.dylib 0x0000000181d92a14 0x181d91000 + 6676
7 libdispatch.dylib 0x0000000181d9c96c 0x181d91000 + 47468
8 libdispatch.dylib 0x0000000181d9d2fc 0x181d91000 + 49916
9 libdispatch.dylib 0x0000000181d9dd20 0x181d91000 + 52512
10 libdispatch.dylib 0x0000000181da603c 0x181d91000 + 86076
11 libsystem_pthread.dylib 0x000000018203af1c 0x18203a000 + 3868
12 libsystem_pthread.dylib 0x000000018203ab6c 0x18203a000 + 2924
Thread 17 name: Dispatch queue: com.apple.root.default-qos
Thread 17 Crashed:
0 libsystem_kernel.dylib 0x0000000181f27048 0x181f06000 + 135240
1 libsystem_kernel.dylib 0x0000000181f21bdc 0x181f06000 + 113628
2 libsystem_kernel.dylib 0x0000000181f21c08 0x181f06000 + 113672
3 TCC 0x0000000184ea4980 0x184ea3000 + 6528
4 TCC 0x0000000184ea48a0 0x184ea3000 + 6304
5 TCC 0x0000000184ea813c 0x184ea3000 + 20796
6 libxpc.dylib 0x0000000182075d44 0x182071000 + 19780
7 libxpc.dylib 0x0000000182075c80 0x182071000 + 19584
8 libdispatch.dylib 0x0000000181d93134 0x181d91000 + 8500
9 libdispatch.dylib 0x0000000181daabfc 0x181d91000 + 105468
10 libdispatch.dylib 0x0000000181d99a8c 0x181d91000 + 35468
11 libdispatch.dylib 0x0000000181d9fcf4 0x181d91000 + 60660
12 libdispatch.dylib 0x0000000181d9fa38 0x181d91000 + 59960
13 libsystem_pthread.dylib 0x000000018203b06c 0x18203a000 + 4204
14 libsystem_pthread.dylib 0x000000018203ab6c 0x18203a000 + 2924
Thread 18 name: WTF::AutomaticThread
Thread 18:
0 libsystem_kernel.dylib 0x0000000181f280f0 0x181f06000 + 139504
1 libsystem_pthread.dylib 0x000000018203ece4 0x18203a000 + 19684
2 JavaScriptCore 0x0000000188de5340 0x188dd6000 + 62272
3 JavaScriptCore 0x000000018976533c 0x188dd6000 + 10023740
4 JavaScriptCore 0x00000001892d0170 0x188dd6000 + 5218672
5 JavaScriptCore 0x000000018975127c 0x188dd6000 + 9941628
6 JavaScriptCore 0x0000000188de170c 0x188dd6000 + 46860
7 JavaScriptCore 0x0000000188de164c 0x188dd6000 + 46668
8 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
9 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
10 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 19 name: WTF::AutomaticThread
Thread 19:
0 libsystem_kernel.dylib 0x0000000181f280f0 0x181f06000 + 139504
1 libsystem_pthread.dylib 0x000000018203ece4 0x18203a000 + 19684
2 JavaScriptCore 0x0000000188de5340 0x188dd6000 + 62272
3 JavaScriptCore 0x000000018976533c 0x188dd6000 + 10023740
4 JavaScriptCore 0x00000001892d0170 0x188dd6000 + 5218672
5 JavaScriptCore 0x000000018975127c 0x188dd6000 + 9941628
6 JavaScriptCore 0x0000000188de170c 0x188dd6000 + 46860
7 JavaScriptCore 0x0000000188de164c 0x188dd6000 + 46668
8 libsystem_pthread.dylib 0x000000018203c2b4 0x18203a000 + 8884
9 libsystem_pthread.dylib 0x000000018203c180 0x18203a000 + 8576
10 libsystem_pthread.dylib 0x000000018203ab74 0x18203a000 + 2932
Thread 20:
0 libsystem_kernel.dylib 0x0000000181f28d80 0x181f06000 + 142720
1 libsystem_pthread.dylib 0x000000018203aeec 0x18203a000 + 3820
2 libsystem_pthread.dylib 0x000000018203ab6c 0x18203a000 + 2924
Thread 21:
0 libsystem_pthread.dylib 0x000000018203ab68 0x18203a000 + 2920
Thread 22 name: Dispatch queue: com.facebook.react.AsyncLocalStorageQueue
Thread 22:
0 libsystem_kernel.dylib 0x0000000181f284a4 0x181f06000 + 140452
1 libsystem_kernel.dylib 0x0000000181f09950 0x181f06000 + 14672
2 Foundation 0x0000000182d25dd4 0x182d05000 + 134612
3 Foundation 0x0000000182e0fa24 0x182d05000 + 1092132
4 Keybase 0x0000000104bc043c 0x104b28000 + 623676
5 Keybase 0x0000000104bc12e0 0x104b28000 + 627424
6 CoreFoundation 0x000000018241dcd0 0x1822d0000 + 1367248
7 CoreFoundation 0x00000001822fc56c 0x1822d0000 + 181612
8 CoreFoundation 0x000000018230101c 0x1822d0000 + 200732
9 Keybase 0x0000000104bcfbac 0x104b28000 + 687020
10 Keybase 0x0000000104c109e8 0x104b28000 + 952808
11 Keybase 0x0000000104c10748 0x104b28000 + 952136
12 libdispatch.dylib 0x0000000181d92a54 0x181d91000 + 6740
13 libdispatch.dylib 0x0000000181d92a14 0x181d91000 + 6676
14 libdispatch.dylib 0x0000000181d9c96c 0x181d91000 + 47468
15 libdispatch.dylib 0x0000000181d9d2fc 0x181d91000 + 49916
16 libdispatch.dylib 0x0000000181d9dd20 0x181d91000 + 52512
17 libdispatch.dylib 0x0000000181da603c 0x181d91000 + 86076
18 libsystem_pthread.dylib 0x000000018203af1c 0x18203a000 + 3868
19 libsystem_pthread.dylib 0x000000018203ab6c 0x18203a000 + 2924
Thread 23:
0 libsystem_pthread.dylib 0x000000018203ab68 0x18203a000 + 2920
Thread 17 crashed with ARM Thread State (64-bit):
x0: 0x000000000000000b x1: 0x0000000000000000 x2: 0x000000013a11a7b8 x3: 0x0000000000000022
x4: 0x000000013a11a7ec x5: 0x0000000000000000 x6: 0x00fb000004220102 x7: 0x0000000000000850
x8: 0x0000000000000020 x9: 0x1f1e3ce4d540002e x10: 0x0100000100000000 x11: 0x0201100010000e98
x12: 0x0000000000000000 x13: 0x2070706120656874 x14: 0x6968742073657375 x15: 0x002e617461642073
x16: 0x0000000000000209 x17: 0x0201100110000e98 x18: 0xfffffff01509925c x19: 0x0000000000000000
x20: 0x000000013a11a7ec x21: 0x0000000000000022 x22: 0x000000013a11a7b8 x23: 0x0000000000000000
x24: 0x000000000000000b x25: 0x00000001c487e5c0 x26: 0x00000000200005ff x27: 0x00000001abdb0208
x28: 0x00000001b1d44a40 fp: 0x000000016bdc2be0 lr: 0x0000000181f21bdc
sp: 0x000000016bdc2ba0 pc: 0x0000000181f27048 cpsr: 0x40000000
!!!! ... Truncated, see Gist: https://gist.github.com/Flaque/04e58f05d112e17d59eec5bfcf20ad26 !!!!
EDIT: Truncated the log a bit and put the entire thing here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the iOS app's Info.plist and the photo-download flow described in the reproduction steps. Verify how the app declares access to the photo library, especially NSPhotoLibraryAddUsageDescription, then reproduce the download on iOS 11.2.2 or a comparable iOS environment. Done means saving a received photo no longer crashes because of a missing privacy usage description.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, react-native
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100