keybase / keybase/client

Support for non-standard download directories

Open
#10,379 2 comments 4 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.2k
Forks
1.3k
Avg merge
12h 58m
Merged PRs (30d)
56

Description

It would be nice, if Keybase would support non-standard download directories for files shared in chat. On my setup the `Downloads` directory is missing so Keybase just created one and put the downloaded file there.

I see that [this is the place](https://github.com/keybase/client/blob/49653314fe2240134cf90c6ae86efa5eb6f7f1fe/shared/util/file.desktop.js#L32) that seems to control this right now. Also looks like at least on debian (and thus ubuntu) there's a package called `xdg-user-dirs` that manages the location of these "special" directories. So indeed my downloads directory is specified in `$HOME/.config/user-dirs.dirs`.

Runnig on Keybase GUI Version: 1.0.40-20180123171551+6ea38e5a0

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in shared/util/file.desktop.js around line 32 and inspect how shared chat files choose their download directory. Compare that behavior with the xdg-user-dirs configuration in $HOME/.config/user-dirs.dirs, then verify that downloads use the configured location instead of creating a default Downloads directory.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.