key4hep / key4hep/k4FWCore

downstream consumer tests are no longer run?

Open
#246 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
14
Forks
34
Avg merge
2d 23h
Merged PRs (30d)
6

Description

I just realized this in #230. It looks like the https://github.com/key4hep/k4FWCore/tree/main/test/downstream-project-cmake-test is no longer built in CI (and it has been like this for quite some time?)

I think in this project it would make sense to ensure that we don't break the downstream cmake config accidentally in CI.

edit: we technically have the downstream workflow that tests all currently used real world features, but given it's frequent unrelated failures, I think it would be useful to have a dedicated test

edit: We have the downstream build workflow that should cover all "real world use cases", but given that that has been rather flaky recently, I still think a dedicated small workflow (or addition to an existing workflow) would make sense.

Contributor guide

Open the contributing guide

Research direction

Start with test/downstream-project-cmake-test and the repository's existing downstream CI workflow. Check why this test is no longer built and compare it with the current real-world downstream workflow. Done means a dedicated or extended CI job reliably builds the downstream CMake test without depending on unrelated flaky checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, github-actions
Domain
build-system, ci-cd, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.