key4hep / key4hep/CLDConfig

Digitised muon system hits have no time

Open
#96 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
21
PR merge metrics
No merged PRs in 30d

Description

However, the `DDSimpleMuonDigi` digitiser [should calculate it](https://github.com/iLCSoft/DDMarlinPandora/blob/e4c53a5bb99a1995376c8d64ec98e6bb749d6074/src/DDSimpleMuonDigi.cc#L191)

I guess the only missing ingredient on our side is to set the `MuonTimeTreshold` to a value similar to the `MuonTreshold` in https://github.com/key4hep/CLDConfig/blob/bf0cec98823ed6aa7b00174cde9e6061c061e3ab/CLDConfig/CaloDigi/MuonDigi.py#L26-L33

(The default values in the digitiser seem to be in a different unit system e.g. off by one order of magnitude)

@herrmannlena: let us know if that fixes things for you.

@andresailer: any thoughts? :)

Contributor guide

Open the contributing guide

Research direction

Inspect CLDConfig/CaloDigi/MuonDigi.py and the referenced DDSimpleMuonDigi.cc calculation, comparing MuonTimeTreshold with MuonTreshold and their units. Verify the digitisation configuration produces muon hits with time information; done when the threshold is set consistently and the resulting hits have time.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.