kevva / kevva/bin-wrapper

Should not make assumptions based on process architecture

Open
#48 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
152
Forks
65
PR merge metrics
No merged PRs in 30d

Description

If I'm using a 32-bit version of Node on a 64-bit version of Windows, and only configure a win32 x64 binary using bin-wrapper, it throws the following error:

No binary found matching your system. It's probably not supported.

This is misleading, as there is a binary matching my system. The real error is something like "No binary found matching the architecture of your Node.js process", as it's not even checking the system architecture. The only time it should care about the architecture of the Node.js process is if you want to load something into that process itself (for example, a DLL file).

See https://github.com/facebook/flow/issues/2288

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing bin-wrapper's architecture matching and error-reporting entry points; the issue provides no file or test names. Reproduce the 32-bit Node.js on 64-bit Windows case with a win32 x64 binary, then verify that matching is based on the relevant system architecture and that unsupported cases report the actual mismatch.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.