kernelci / kernelci/dashboard

move some search params to index route

Open
#1,020 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Frontend technical debt
Dominant language
Python
Stars
9
Forks
31
Avg merge
3d 19h
Merged PRs (30d)
16

Description

If the search parameter is not needed in any other route outside the route where it was created, than it should be declared inside an index route to not make the children routes inherit unnecessary search parameters. One example would be listingSize that only makes sense in tree/hardware listing. The same goes for treeSearch and hardwareSearch

https://tanstack.com/router/latest/docs/framework/react/routing/routing-concepts#index-routes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the route definitions for the tree and hardware listing routes, then compare them with TanStack Router's React index-routes guidance linked in the issue. Identify where listingSize, treeSearch, and hardwareSearch are declared, and confirm that each is scoped to its index route rather than inherited by child routes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.