keplergl / keplergl/kepler.gl

[Bug] Kepler 2.5 CustomMapPopoverFactory injection props passed without context

Open
#1,649 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
12k
Forks
2k
Avg merge
1d 5h
Merged PRs (30d)
66

Description

**Describe the bug**
kepler version 2.5
On a **CustomMapPopoverFactory** injection the prop object has no data object returned based on the point clicked
no problem on the 2.4 version

**To Reproduce**
Steps to reproduce the behavior:
1. use kepler 2.5
2. create a CustomMapPopoverFactory injection
``` javascript
const CustomMapPopoverFactory = (...deps) => {
const MapSidepanel = props => {
console.log(props.layerHoverProp.data)
```

4. all the data of the layer is returned not the data specific to the point

**Expected behavior**
Data should be field with the informations specific to the clicked point

**Desktop (please complete the following information):**
- OS: Ubuntu 20.04.2
- Browser firefox
- Kepler Version 2.5

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue in Kepler 2.5 with a CustomMapPopoverFactory injection and inspect props.layerHoverProp.data for the clicked point. Compare the same behavior with Kepler 2.4; the work is done when the injected props expose data specific to the clicked point rather than all layer data.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.