kentcdodds / kentcdodds/use-deep-compare-effect

Error when object in dependencies set to NULL.

Open
#63 2 comments 5 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.9k
Forks
88
PR merge metrics
No merged PRs in 30d

Description

- `use-deep-compare-effect` version: 1.8.1
- `node` version: 14.17.6
- `npm` version: 6.14.15

Relevant code or config

What you did: Implemented useDeepCompareEffect on object that can be null.

What happened: When setting it`s value to null, error occurs.

Contributor guide

Open the contributing guide

Research direction

No file, test, or stack trace is named. Start by reproducing the reported use-deep-compare-effect 1.8.1 behavior with an object dependency set to null, then inspect the TypeScript implementation and add coverage showing that this case no longer throws.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.