kentcdodds / kentcdodds/react-ava-workshop
Branch coverage is off somehow. Because of super?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 191
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
Great workshop!
I noticed that my test coverage is 100% on almost everything, but not for % Branch in Toggle.js and CustomerList.js. In Toggle.js I get 5/6 branches coverage, in CustomerList.js I get 3/4 branches coverage. I don't hink I did anything wrong, I also get these coverages when I switch to the master branch. It might be the nyc/istanbul version. I see there is an issue that I think is causing this.
How could I go about and fix this in your example files?
Thanks!
Martijn
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting Toggle.js and CustomerList.js and the coverage output on the master branch. Review the linked Istanbul issue and compare the reported branch counts; this is done when the example files no longer show the unexpected branch-coverage gaps or the expected limitation is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100