kentcdodds / kentcdodds/kcd-scripts
lintstagedrc.js failes on Windows
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 889
- Forks
- 205
- PR merge metrics
- No merged PRs in 30d
Description
nodeversion: 10.10.0npm(oryarn) version: 6.0.0
Relevant code or config
npm run precommit
Problem description:
I'm working on a fork of kcd-scripts for my own company's purposes and while testing the lintstagedrc.js file failes on Windows. Probably has to do with #8 or is very similar. I also noticed this when working on React-Testing-Library when I went to commit, again lintstagedrc.js fails.
Unfortunately I'm not versed enough in the fs and path operators to figure out how to change \ for /. Unless we write a dirty method to check for win32 and do a global replace on the path string, tranding slashes. But I don't know what other problems might arise from that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lintstagedrc.js and run npm run precommit in a Windows environment using the reported Node 10.10.0 setup. Review the filesystem and path handling, with issue #8 as related context. Done means the precommit command completes successfully on Windows without the lintstagedrc.js failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100