kennethreitz / kennethreitz/maya

Package not compatible with next version of tzlocal

Open
#191 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
3.4k
Forks
197
PR merge metrics
No merged PRs in 30d

Description

The next version of `tzlocal` will [switch from using `pytz` zones to `zoneinfo`](https://github.com/regebro/tzlocal/pull/92) (which is generally a good idea), which will break this package, since `zoneinfo` zones don't have the same interface as `pytz` zones.

You should probably pin the version of `tzlocal` ASAP, and/or add in some logic to detect `zoneinfo` zones and convert them to whatever you want.

In the longer term, you should probably also migrate away from `pytz` and on to `zoneinfo`. I have a [`pytz-deprecation-shim`](https://pytz-deprecation-shim.readthedocs.io/en/latest/) module that should help ease the pain (though it is not 100% backwards compatible - in the [migration guide](https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html) you'll find that the [semantics of datetime addition are slightly different](https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html#handling-datetime-arithmetic-normalizing-datetimes)).

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating where the package consumes tzlocal and pytz, then reproduce the incompatibility with zoneinfo; done means the package has a defined compatibility strategy and coverage for the affected timezone behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.