kataras / kataras/methodoverride

A missing inject-able defaults opts for new constructor (builder)

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
Go
Stars
7
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Hi,

Great package!

![2019-11-30_01-05](https://user-images.githubusercontent.com/9432921/69893158-867c0a00-130d-11ea-978d-7c03f7492366.png)

I think, it is better to inject these defaults opts by passing it to the constructor instead of having a predefined one in the function body. In my point of view, this new function is behaving like a builder. Maybe you could provide a builder and constructor for this package.

Best regards,
Donutloop

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.