kataras / kataras/jwt

Unnecessary custom base64 implementation

Open
#5 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
212
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Go has [RawStdEncoding](https://pkg.go.dev/encoding/base64#pkg-variables) which makes this unnecessary:

https://github.com/kataras/jwt/blob/1639fcff96f82f7ff118fcff6e1fbd0e01754f2c/token.go#L247

Not trying to nitpick here, rather I think security-wise it's dangerous as a concept to mutate untrusted input data before it's fed to a signature validation algorithm

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.