kata-ai / kata-ai/merapi

There should be callback or promise based implementation of Container.start()

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
27
Forks
6
PR merge metrics
No merged PRs in 30d

Description

The sleep-based testing scenario is quite unreliable, especially in slow machines (See: https://github.com/kata-ai/merapi-proxy/blob/6f6f81d23c6c6e1fbf4910e7e1cd6f12ec01076e/test/async_test.spec.js#L103).
Callback/promise-based is going to be more robust in this case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.