kasuken / kasuken/LearnStack

[Blocker] Add a PR CI workflow and make tests gate the deploy

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
HTML
Stars
10
Forks
0
Avg merge
2h 52m
Merged PRs (30d)
20

Description

Tier 1 — release blocker

Problem

Three separate gaps:

  1. The deploy workflow runs tests with continue-on-error: true, so a failing test never blocks a production deploy.
  2. It runs dotnet test --no-build at solution level after building only LearnStack.csproj, so the test project is likely never built and the tests probably do not execute at all — the swallowed error hides this.
  3. There is no PR build workflow at all: the only workflow triggers on push to main and deploys straight to production.
Evidence
  • .github/workflows/azure-app-service.yml:91-92
  • .github/workflows/ contains only azure-app-service.yml
Proposed fix
  1. Add .github/workflows/ci.yml: restore, build LearnStack.sln, dotnet test on pull_request and push.
  2. Mark it a required status check on main.
  3. In the deploy workflow, build the solution and drop continue-on-error.
Acceptance criteria
  • A PR with a failing test cannot be merged
  • A failing test blocks the deploy job
  • Test results are visible in the workflow summary

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading .github/workflows/azure-app-service.yml around lines 91-92 and inspect the LearnStack.sln and LearnStack.csproj build targets. Add .github/workflows/ci.yml using restore, solution build, and dotnet test for pull requests and pushes, then update the deploy workflow. Done means required PR checks and deploy tests visibly fail on test failure, with the workflow summary showing results.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, csharp, github-actions
Domain
ci-cd, cloud, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.