For addition adding incrementing grading makes sense, I can't make sense out of the incrementing it for multiplication too, potential bug?
Open
- Dominant language
- Jupyter Notebook
- Stars
- 17.6k
- Forks
- 2.8k
- PR merge metrics
- No merged PRs in 30d
Description
def __mul__(self, other):
other = other if isinstance(other, Value) else Value(other)
out = Value(self.data * other.data, (self, other), '*')
def _backward():
self.grad += other.data * out.grad
other.grad += self.data * out.grad
out._backward = _backward
return out
If you have an expression of type (x*y)*(x*z) then the gradient w.r.t x is not additive, right?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.