karpathy / karpathy/makemore

No updates to `self.logits` with bigram counts in Bigram class

Open
#28 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4.3k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Hello everyone, i've made a `makemore.py` file (same as https://github.com/karpathy/makemore/blob/master/makemore.py) with only Bigram model class as of now.

while running it with `python makemore.py -i names.txt -o names --type bigram` arguments, wouldn't it just keep training, where it actually isn't doing anything coz there is no operation in forward pass.

Has anyone succesfully run it? Or it is yet to be completed?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.