karpathy / karpathy/deep-vector-quantization

About the input of F.gumbel_softmax

Open
#7 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
655
Forks
60
PR merge metrics
No merged PRs in 30d

Description

From my understanding, the input of `F.gumbel_softmax` (i.e., the` logits` parameter) should be the \log of a discrete distribution. However, I didn't see any softmax or log_softmax before the gumbel_softmax. It seems like you're treating the output of `self.proj` as log-probabilities with the range of (-inf, inf), which indicates that the probabilities of the discrete distribution have the range of (0, inf).

I'm curious about why you don't use softmax to normalize things into (0, 1) and make the sum of them to be 1. Does the mathematics still make sense without normalizing?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.