karma-runner / karma-runner/karma
script-launcher : bad script browser recognition
- Dominant language
- JavaScript
- Stars
- 12k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Hi all, just wanted to note that after updating to latest karma (0.10.2) , if someone's got problem with "script browsers" ( we use a .bat to run IE tester with specific IE versions) , it could be because of the "browser type recognition".
It gets recognized as "script browser" only if it's path it's absolute
lib\launcher.js line 19
``` Javascript
// TODO(vojta): determine script from name
if (name.indexOf('/') !== -1) {
name = 'Script';
}
```
we just put a temporary work-around like this
``` js
// TODO(vojta): determine script from name
if (name.indexOf('/') !== -1 || name.indexOf('.bat') !== -1) {
name = 'Script';
}
```
Contributor guide
Assessment
This issue has not been assessed yet.