karma-runner / karma-runner/karma

Disconnecting a browser sends `browser_error` event to reporters

Open
#2,853 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

### Expected behaviour

Disconnecting a browser shouldn't send `browser_error` to reporters.

### Actual behaviour

Start karma server and capture a browser manually. Once a test run is done, close the browser manually.
As a result, reporter's `onBrowserError` method is called back with `error='Disconnectedundefined'`: https://github.com/karma-runner/karma/blob/v1.7.1/lib/browser.js#L40

Seems there is no much sense in this event after the test run. The problem is that reporters should filter out such events as it's not an error.

### Environment Details

- Karma version (output of `karma --version`): 1.7.1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.