kangax / kangax/html-minifier

Error on PHP when not ending in ?>

Open
#1,124 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
577
PR merge metrics
No merged PRs in 30d

Description

in a PHP file, the closing tag is optional.

This works in html-minifier:
```php
//begining of file

//end of file
```

This gives an error in html-minifier:
```php
//begining of file

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the two PHP examples in html-minifier and trace the parsing path that handles the optional closing tag. Done means a PHP file without ?> no longer errors while the existing example with ?> continues to be processed correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.