kangax / kangax/html-minifier

Should not strip type="text" from <input> tag due to CSS rules needing it

Open
#1,075 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
577
PR merge metrics
No merged PRs in 30d

Description

Yes, I know that type="text" is the default for an tag, so therefore it should be safe to strip it out.

The problem is when there are css rules that assume that this attribute has not been stripped out.

e.g.
```
input[type=text], input[type=email], input[type=submit] {
...
}
```

It just seems safer to not strip that out.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no source file or test. Start by locating the logic that strips the default input type attribute and any related tests; done means explicit type="text" is preserved so selectors such as input[type=text] continue to match.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.