kaisermann / kaisermann/svelte-loadable

Add tests

Open
#27 0 comments 3 reactions 1 assignee View on GitHub

@kaisermann is already working on this.

Since Feb 2, 2020.

help wanted
Dominant language
Svelte
Stars
321
Forks
12
PR merge metrics
No merged PRs in 30d

Description

I may get to this at some point, but wanted to note it in case you're already working on it.

Some cases (not exhaustive):

- basic scenario: ``
- with props: ``
- with page loader: ` getComponentDynamically()} />`
- with registered loader: ``
- with default and loading slot: `

loading...
...`
- others...but those ^ would be a good start

Could use [cypress](https://docs.cypress.io/guides/overview/why-cypress.html#In-a-nutshell) and [cypress-svelte-unit-test](https://github.com/bahmutov/cypress-svelte-unit-test). Or the test library that svelte itself uses. Or whatever the implementer's heart desires, so long as it asserts what needs to be asserted :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.