jwyang / jwyang/face-alignment
Problem in split in node
- Dominant language
- MATLAB
- Stars
- 321
- Forks
- 190
- PR merge metrics
- No merged PRs in 30d
Description
Dear @jwyang
I downloaded the program and tested.
It works good.
But, I found a problem in the function splitnode() in train_randomfs.m
There's code to get image index for the left and right child nodes:
```
lcind = find(pdfeats(ind_colmax(ind_max), :) < thresh);
rcind = find(pdfeats(ind_colmax(ind_max), :) >= thresh);
```
As the node goes deep, lcind and rcind only refer the front index of training images.
I think it should be changed as
```
lcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) < thresh));
rcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) >= thresh));
```
Then, lcind and rcind come from original image index.
Please check it.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in train_randomfs.m at splitnode() and inspect how ind_samples is maintained as nodes become deeper. Verify that the left and right child indices continue to refer to the original training images, then run the available training workflow to confirm the split completes correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- matlab
- Domain
- computer-vision, machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100