jverdi / jverdi/JVFloatLabeledTextField
Incorrect placeholderYPadding for case placeholderYPadding > floatingLabelYPadding
- Dominant language
- Objective-C
- Stars
- 7.1k
- Forks
- 720
- PR merge metrics
- No merged PRs in 30d
Description
Hi. I found one strange bug: if i want set floatingLabelYPadding is 40, and placeholderYPadding is, for example, 70 (> 40), placeholderYPadding will be 40. You can find this incorrect logic in methods insetRectForBounds, clearButtonRectForBounds, etc.. All methods that use maxTopInset method. Can you check this?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating maxTopInset and the methods that use it, including insetRectForBounds and clearButtonRectForBounds. Reproduce the issue with floatingLabelYPadding set to 40 and placeholderYPadding set to 70, then verify that the affected layout calculations preserve the larger placeholder padding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100