jvandemo / jvandemo/generator-angular2-library
inline templates and styles needs regex improvement
- Dominant language
- JavaScript
- Stars
- 740
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
I notices some wrong behavior when trying to use the new inline features of v9.0.0.
After research i found following things:
- the regex for tempalteUrl and styleUrls works only with ' not with "
- the regex for templateUrl and styleUrls parses also the comments and strings. It should only parse the related property
here is a test that shows the testcases: https://regex101.com/r/M6pB9M/2
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the regex101 example linked in the issue, then locate the generator regexes that process templateUrl and styleUrls. Verify the cases for both quote styles and ensure matches are limited to the related properties rather than comments or strings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100