jvandemo / jvandemo/generator-angular2-library

Feature request: Allow double quotes for template inlining

Open
#189 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
740
Forks
116
PR merge metrics
No merged PRs in 30d

Description

As far as I understand, the regex in the gulp function inlineTemplate() only searches for a string in the format `templateUrl: '...'` and does not cover double quotes notation like `templateUrl: "..."`.
I can create a pull request for this but are there other parts in the project that expect us to use single quotes?

Contributor guide

No contributing guide indexed for this repository

Research direction

Find the gulp function inlineTemplate() and inspect the regex that currently matches templateUrl values. Done means double-quoted templateUrl references are inlined while existing single-quoted references continue to work; check the project's relevant validation after the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.