justadudewhohacks / justadudewhohacks/opencv4nodejs
Wrong kmeans argument sequence?
Open
- Dominant language
- C++
- Stars
- 5.1k
- Forks
- 826
- PR merge metrics
- No merged PRs in 30d
Description
Hi there!
Argument sequence is different d.ts and unit test.
https://github.com/justadudewhohacks/opencv4nodejs/blob/24bff921c8d9c78500228e4be2d7bcd36e7a3904/lib/typings/cv.d.ts#L114
https://github.com/justadudewhohacks/opencv4nodejs/blob/24bff921c8d9c78500228e4be2d7bcd36e7a3904/test/tests/core/coreTests.js#L106
I think `attempts` and `termCriteria` are reversed.
But I'm not familiar with OpenCV, should fix cc files?
I don't know how to fix it.
Thank you!
Contributor guide
Assessment
This issue has not been assessed yet.