justadudewhohacks / justadudewhohacks/opencv4nodejs

Suggestion for the new electron

Open
#784 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.1k
Forks
826
PR merge metrics
No merged PRs in 30d

Description

Hello, I thought there was a huge problem on your example code for "opencv-electron".

The example source code is written for electron version 1.x.

I thought that it is too old. The current electron version is 11.0.3.

Actually, there are not only the INSTALLATION ISSUE (BUILD ISSUE)

but also "FAILURE ISSUE WHEN REQUIRE A MODULE ON CLIENT".

And, again, I think that was happened because the example source code is for too old version of electron.

Here is my suggestion:
1) Target electron for the latest version
2) Change image management system
- from: require the opencv module and compute at the client-side
- to: load image (client) -> compute (electron-server) -> show the result (client) [IPC]

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.