justadudewhohacks / justadudewhohacks/opencv4nodejs

Compilation with static linking.

Open
#686 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.1k
Forks
826
PR merge metrics
No merged PRs in 30d

Description

Greetings.

I have a proposal to make project compatible with static linking. Having 2.2gb in node_modules is not suitable for many cases.

I managed to compile project with static linking and run simple test. However this is not the first attempt to build nodejs native modules and I know how many troubles it usually causes.

I did it in linux (ubuntu18). binding.gyp main changes are below
Crusial part for GCC (it never works, because the order of libs counts in gcc)

"libraries": [
#"> 8) & 255, (fourCC >> 16) & 255, (fourCC >> 24) & 255);
const videoInfo = {
fourCC: fourCC,
fourCCString: fourCCStr,
frameCount: frameCount,
frameWidth: frameWidth,
frameHeight: frameHeight,
fps: fps,
posFrames: posFrames,
posAviRatio: posAviRatio
};
console.log('videoInfo: ' + JSON.stringify(videoInfo));

Theoretically I am ready to prepare pull request but I do not know the vision of author how it is supposed to be done. Any thoughts?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.