justadudewhohacks / justadudewhohacks/opencv4nodejs

Wrong type in KeyPoint.d.ts for point/pt

Open
#655 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.1k
Forks
826
PR merge metrics
No merged PRs in 30d

Description

Hi, please replace line https://github.com/justadudewhohacks/opencv4nodejs/blob/92cf0b2bee2eaa52e55cd6466cf55d6f6227d423/lib/typings/KeyPoint.d.ts#L4
with
```readonly pt: Point2;```
to match with
https://github.com/justadudewhohacks/opencv4nodejs/blob/02be3b6416b8225efca4d564d64d5db71372babd/cc/features2d/KeyPoint.h#L23
this affect proper TypeScript build when using cv.KeyPoint class.

Thanks, David

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.